[Messenger] Use same buses names #11974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Jul 18, 2019
OskarStark
approved these changes
Jul 23, 2019
|
Could you please squash your commits into one? We cannot squash merge it with our tool if there is a merge commit. Thank you! |
|
@OskarStark the branch name |
|
I know but how does the merge commit goes in then? 🧐 |
|
The merge commit is from the built in merge conflict tool of GitHub. I'm currently on holidays. Will do it when I come back home on august, 1st. |
|
@OskarStark Should be good now. |
|
Thank you @Lctrs. |
OskarStark
added a commit
that referenced
this pull request
Aug 2, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Use same buses names Commits ------- b33a14a [Messenger] Use same buses names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.