Fixed Swiftmailer PHP configuration #11982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. I guess this PR should be for version 4.2 following this rule:
4.0 is not maintained version. Ref: https://symfony.com/doc/current/contributing/documentation/overview.html |
|
Thanks Davide! @gregurco is right and this must go to 4.2 branch, so we changed the branch while merging. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 19, 2019
This PR was submitted for the 4.0 branch but it was merged into the 4.2 branch instead (closes #11982). Discussion ---------- Fixed Swiftmailer PHP configuration Just a fix for a PHP snippet in the Swiftmailer reference configuration. I chose 4.0 as target as it's the branch when this snippet was introduced, let me know if I need to change anything. Commits ------- e1ad33e Fixed Swiftmailer PHP configuration
|
Hey, sorry for not following up yesterday, I was busy and you beat me to it. Apologies for initially targeting the wrong branch, but I'm happy to have made a (small) contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a fix for a PHP snippet in the Swiftmailer reference configuration. I chose 4.0 as target as it's the branch when this snippet was introduced, let me know if I need to change anything.