Skip to content

Mentioned the automatic set of "accept" based on "mimeTypes" #12039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #12024.

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m wondering if this should go on the FileType form field docs. I would be using that field and maybe wondering how to add the mime type stuff and this would tell me. But I think it’s fine either way.

@javiereguiluz
Copy link
Member Author

Ryan, I thought about that ... but the File form field doesn't have an accept option (it's an HTML attribute defined via attr) so it's really hard to mention this feature there 😕

@javiereguiluz
Copy link
Member Author

@OskarStark do you know why this is failing?

Warning, treated as error:

/home/travis/build/symfony/symfony-docs/reference/constraints/File.rst:251: 
WARNING: undefined label: forms-field-guessing (if the link has no caption the 
label must precede a section header)

The reference exists and I think the syntax is correct. Thanks.

@xabbuh
Copy link
Member

xabbuh commented Sep 3, 2019

@javiereguiluz Are you sure? I cannot find the reference.

@javiereguiluz
Copy link
Member Author

It's strange. On my local computer I see this in the main forms.rst file:

image

But in the repository the reference is different: https://raw.githubusercontent.com/symfony/symfony-docs/4.4/forms.rst

.. _form-type-guessing:

@javiereguiluz
Copy link
Member Author

OK, I've just rebased this PR to the latest 4.4 changes, so it should be OK now. Thanks.

javiereguiluz added a commit that referenced this pull request Sep 10, 2019
…pes" (javiereguiluz)

This PR was squashed before being merged into the 4.4 branch (closes #12039).

Discussion
----------

Mentioned the automatic set of "accept" based on "mimeTypes"

Fixes #12024.

Commits
-------

17e1a5a Mentioned the automatic set of \"accept\" based on \"mimeTypes\"
@javiereguiluz javiereguiluz merged commit 17e1a5a into symfony:4.4 Sep 10, 2019
@javiereguiluz javiereguiluz deleted the fix_12024 branch September 10, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants