[Cache] Fix example for using cache tags with TagAwareCacheInterface #12181
Conversation
pavelmaca
changed the title
|
@Nyholm could you please verify this docs change? Thank you 😃 |
There was a problem hiding this comment.
Thanks @pavelmaca for the change and @Nyholm for the review 👍
|
Oh wait. I will review it shortly. |
|
👎 (to be clear) |
|
@pavelmaca can you explain a bit why you did this change or which error do you have? |
|
I did find a bug when testing this out. Maybe that was what @pavelmaca experienced? |
cache.rst
Outdated
|
|
||
| $value0 = $pool->get('item_0', function (ItemInterface $item) { | ||
| $value0 = $pool->get('item_0', function (TagAwareCacheInterface $item) { |
There was a problem hiding this comment.
It is the $pool that should be a TagAwareCacheInterface.
@pavelmaca could you update this PR a little? Could you wrap this code into a function or a class and make sure $pool is a TagAwareCacheInterface?
|
More info here: symfony/symfony#33201 |
|
@Nyholm Your findings are correct in symfony/symfony#33201 Updated doc with function and autowired $pool |
|
|
||
| $value0 = $pool->get('item_0', function (ItemInterface $item) { | ||
| $item->tag(['foo', 'bar']) | ||
| // using autowiring |
There was a problem hiding this comment.
| // using autowiring |
| $value0 = $pool->get('item_0', function (ItemInterface $item) { | ||
| $item->tag(['foo', 'bar']) | ||
| // using autowiring | ||
| public function listProducts(TagAwareCacheInterface $pool) |
There was a problem hiding this comment.
Update $pool to $myCachePool to match the config below.
There was a problem hiding this comment.
Maybe use a more generic name than listProducts. Maybe foo?
I think this would make sense in this case, otherwise this must be a tage with controller arguments tag 👍 👍 for a class + injection |
|
I tried to merge this but I couldn't fix the conflicts ... so I created in #12398 a new pull request with these changes and all the other changes requested by Tobias. @pavelmaca I kept your original commit, so you'll get credit for this contribution. Thanks. |
…, javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- [Cache] Improved the example about cache tags This continues the work started in #12181. Commits ------- f9d438f Fixed code 2651f92 [Cache] Improved the example about cache tags ce0c625 [Cache] Fix example for using cache tags with TagAwareCacheInterface
Using Cache Tags section has invalid example. Should use TagAwareCacheInterface.