Skip to content

Move doctrine/annotations instructions #12190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2019
Merged

Move doctrine/annotations instructions #12190

merged 1 commit into from
Sep 24, 2019
+2 −2

Conversation

makmaoui
Copy link
Contributor

Move doctrine/annotation instructions to first example using annotation loader

@makmaoui
Move doctrine/annotations instructions
10a3b1c 
Move doctrine/annotation instructions to first example using annotation loader
@xabbuh
Copy link
Member

xabbuh commented Aug 26, 2019

Maybe we should not use the AnnotationLoader but use a placeholder $loader variable instead. Sticking to annotations here would be confusing for anyone wanting to use YAML or XML files for example. Later on we do explain how to create the loader anyway.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 24, 2019
javiereguiluz added a commit that referenced this pull request Sep 24, 2019
@javiereguiluz
minor #12190 Move doctrine/annotations instructions (makmaoui)
e6ca8a4 
This PR was merged into the 4.3 branch.

Discussion
----------

Move doctrine/annotations instructions

Move doctrine/annotation instructions to first example using annotation loader

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

10a3b1c Move doctrine/annotations instructions
@javiereguiluz javiereguiluz merged commit 10a3b1c into symfony:4.3 Sep 24, 2019
@javiereguiluz
Copy link
Member

@makmaoui thanks for this contribution! However, while merging we reworded it to do what @xabbuh proposed. In any case, even if your original contribution wasn't merged, it helped us a lot to improve things. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@makmaoui @xabbuh @javiereguiluz @wouterj @carsonbot