Skip to content

[Console] Added SymfonyStyle::definitionList() and SymfonyStyle::horizontalTable() #12293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Sep 9, 2019

fixes #12286

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please add a versionadded directive below each example.

@javiereguiluz what do you think of adding screenshots? 🤔

@javiereguiluz
Copy link
Member

@OskarStark no screenshots please (because they are very hard to maintain), but in the future we'll add .. code-block:: terminal examples to show the result of each method.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 10, 2019
javiereguiluz added a commit that referenced this pull request Sep 10, 2019
…nyStyle::horizontalTable() (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Added SymfonyStyle::definitionList() and SymfonyStyle::horizontalTable()

fixes #12286

Commits
-------

073cc9e [Console] Added SymfonyStyle::definitionList() and SymfonyStyle::horizontalTable()
@javiereguiluz javiereguiluz merged commit 073cc9e into symfony:4.4 Sep 10, 2019
@javiereguiluz
Copy link
Member

Thanks Grégoire! I added the versionadded directives while merging.

@lyrixx lyrixx deleted the console-hori branch September 10, 2019 13:09
@lyrixx
Copy link
Member Author

lyrixx commented Sep 10, 2019

Thanks @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants