Update unit_testing.rst #12409
Merged
Update unit_testing.rst #12409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following https://symfony.com/doc/current/create_framework/index.html tutorial, after The Separation of Concerns part we don't have our old routes /hello or /bye, so this test can't pass. Also we can't run tests with only 'phpunit'
|
Good catch! Both chapters felt disconnected. That is no longer the case. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 3, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Update unit_testing.rst Following https://symfony.com/doc/current/create_framework/index.html tutorial, after The Separation of Concerns part we don't have our old routes /hello or /bye, so this test can't pass. Also we can't run tests with only 'phpunit' <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- dcad5eb Update unit_testing.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://symfony.com/doc/current/create_framework/index.html tutorial, after The Separation of Concerns part we don't have our old routes /hello or /bye, so this test can't pass.
Also we can't run tests with only 'phpunit'