Fix construction of SmtpTransport in Mailer docs #12531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot would you mind give 👍 or 👎 on this? Thanks 🙏 |
fabpot
approved these changes
Nov 4, 2019
|
Thanks for fixing this bug Paweł. |
OskarStark
added a commit
that referenced
this pull request
Nov 4, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix construction of SmtpTransport in Mailer docs Changed `SmtpTransport` to `EsmtpTransport` in standalone component docs. `SmtpTransport::__construct()` requires instance of `AbstractStream` (see https://github.com/symfony/mailer/blob/master/Transport/Smtp/SmtpTransport.php#L41). Construction with host name is available in `EsmtpTransport` (https://github.com/symfony/mailer/blob/master/Transport/Smtp/EsmtpTransport.php#L33) Commits ------- c66c4af Fix construction of SmtpTransport in Mailer docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
SmtpTransporttoEsmtpTransportin standalone component docs.SmtpTransport::__construct()requires instance ofAbstractStream(see https://github.com/symfony/mailer/blob/master/Transport/Smtp/SmtpTransport.php#L41). Construction with host name is available inEsmtpTransport(https://github.com/symfony/mailer/blob/master/Transport/Smtp/EsmtpTransport.php#L33)