Skip to content

[Doctrine] Don't mention invokable listeners in 4.3 #12600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Nov 6, 2019

This feature was added in 4.4. See https://symfony.com/blog/new-in-symfony-4-4-simpler-event-listeners#invokable-doctrine-entity-listeners

Beware mergers: this must be reverted in 4.4 while merging ... and a .. versionadded:: 4.4 directive must be added ... and removed later in master.

wouterj added a commit that referenced this pull request Nov 9, 2019
…reguiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

[Doctrine] Don't mention invokable listeners in 4.3

This feature was added in 4.4. See https://symfony.com/blog/new-in-symfony-4-4-simpler-event-listeners#invokable-doctrine-entity-listeners

Beware mergers: this must be reverted in 4.4 while merging ... and a `.. versionadded:: 4.4` directive must be added ... and removed later in master.

Commits
-------

fae64fc [Doctrine] Don't mention invokable listeners in 4.3
wouterj added a commit that referenced this pull request Nov 9, 2019
…3 (javiereguiluz)"

This reverts commit 9949cfd, reversing
changes made to c2f93ef.
@wouterj wouterj merged commit fae64fc into symfony:4.3 Nov 9, 2019
wouterj added a commit that referenced this pull request Nov 9, 2019
* 4.4:
  [#12600] Added versionadded for invokable listeners
  Revert "bug #12600 [Doctrine] Don't mention invokable listeners in 4.3 (javiereguiluz)"
  [#12584] Small tweaks
  Add WeekType Documentation
  [Doctrine] Don't mention invokable listeners in 4.3
  [Messenger] update events for 4.4
  Use normalizer context constants everywhere
@wouterj
Copy link
Member

wouterj commented Nov 9, 2019

Thanks for the quick reaction! (and detailed merge instructions)

Merged up and reverted in 0b76608 and added versionadded in 9bfa4ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants