Skip to content

[DependencyInjection] EnvVarProcessor - adding section about datetime prefix #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DependencyInjection] EnvVarProcessor - adding section about datetime prefix #12709

wants to merge 1 commit into from

Conversation

chr-hertel
Copy link
Contributor

@chr-hertel chr-hertel commented Nov 27, 2019 •
edited
Loading

@chr-hertel chr-hertel mentioned this pull request Nov 27, 2019
Closed
@OskarStark
Copy link
Contributor

Hi Christopher 👋
This contribution is really appreciated. Could you find out in which version it was merged to add a corresponding versionadded directive and target the right branch?

Thanks 👍

@chr-hertel
Copy link
Contributor Author

i think this is going to be master, in case it gets merged ;)

@OskarStark
Copy link
Contributor

Ah sorry I missed the CodePR, I only clicked the issue!

@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Nov 27, 2019
@OskarStark OskarStark added this to the 5.1 milestone Nov 27, 2019
OskarStark
OskarStark reviewed Nov 27, 2019
View reviewed changes
configuration/env_var_processors.rst
.. note::

It is also possible to use ``DateTimeImmutable`` instead by
using ``datetime_immutable`` as prefix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using ``datetime_immutable`` as prefix.
using ``datetime_immutable`` as prefix.
.. versionadded:: 5.1
The ``datetime`` and ``datetime_immutable`` processors were introduced in Symfony 5.1.

@chr-hertel
Copy link
Contributor Author

PRs is closed, closing here as well

@chr-hertel chr-hertel closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
DependencyInjection Status: Needs Review Waiting Code Merge Docs for features pending to be merged
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@chr-hertel @OskarStark @carsonbot