Add mandatory exit status #12730
Merged
Add mandatory exit status #12730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicate of #12703 |
|
@maxhelias I see, you're right! This PR however also adds the explanation of what the return code actually does. |
Modified all execute() functions and added a note with the new requirement which links to an explanation of exit statuses.
javiereguiluz
force-pushed
the
patch-1
branch
from
d6962af to
49f341f
Compare
|
Robert, we merged both the original pull request and your pull request. We merged in 4.4 to warn about the deprecation and later in 5.0 we mentioned that retruning the integer is now mandatory. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Dec 9, 2019
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #12730). Discussion ---------- Add mandatory exit status Since Symfony 5 it is required to return an integer from a command but this is not yet reflected in the documentation. I've modified the execute() functions and added a note with the new requirement which links to an explanation of exit statuses. Commits ------- 49f341f Add mandatory exit status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Symfony 5 it is required to return an integer from a command but this is not yet reflected in the documentation. I've modified the execute() functions and added a note with the new requirement which links to an explanation of exit statuses.