[Serializer] Remove note about CsvEncoder as_collection flag #12901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default since 5.0
ogizanagi
force-pushed
the
rm_csv_as_collection_note
branch
from
6a0e59a to
0be5b16
Compare
|
Thanks Maxime. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 12, 2020
…flag (ogizanagi) This PR was merged into the 5.0 branch. Discussion ---------- [Serializer] Remove note about CsvEncoder as_collection flag This is the default since 5.0 https://github.com/symfony/symfony/blob/ad7d24109c5d9d9bce66ae57c509eb9baa3cc21b/src/Symfony/Component/Serializer/Encoder/CsvEncoder.php#L47 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0be5b16 [Serializer] Remove note about CsvEncoder as_collection flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default since 5.0
https://github.com/symfony/symfony/blob/ad7d24109c5d9d9bce66ae57c509eb9baa3cc21b/src/Symfony/Component/Serializer/Encoder/CsvEncoder.php#L47