Skip to content

[FrameworkBundle] Template Controller should accept extra arguments #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2020
Merged

[FrameworkBundle] Template Controller should accept extra arguments #12930

merged 1 commit into from
Jan 12, 2020

Conversation

Rebolon
Copy link

@Rebolon Rebolon commented Jan 10, 2020

fix #12929

Not sure of the format of the PR in this project, any help is welcome.

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@Rebolon
Copy link
Author

Rebolon commented Jan 10, 2020

@yceruto it was a pleasure 😎

@javiereguiluz javiereguiluz added this to the 5.1 milestone Jan 12, 2020
@javiereguiluz javiereguiluz merged commit bf737c3 into symfony:master Jan 12, 2020
javiereguiluz added a commit that referenced this pull request Jan 12, 2020
…a arguments (Benjamin RICHARD)

This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] Template Controller should accept extra arguments

fix #12929

Not sure of the format of the PR in this project, any help is welcome.

Commits
-------

bf737c3 [FrameworkBundle] Template Controller should accept extra arguments fix #12929
@javiereguiluz
Copy link
Member

@Rebolon thanks a lot for contributing this feature and the docs too. Congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request Feb 7, 2020
…oute config example (HeahDude)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][Routing] Removed context in template route config example

Continuation of #12930 which only fixed master.

Commits
-------

57a6a18 [FrameworkBundle][Routing] Removed context in template route config example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] TemplateController should accept extra arguments to b…
5 participants