updated configuration reference #1303
Conversation
| secure: true | ||
| httponly: true | ||
| always_remember_me: false | ||
| remember_me_parameter: _remember_me |
There was a problem hiding this comment.
Hey Kevin!
What do you think about the factories? These all seem to be missing now - possible that it's because of the new way of loading this configuration?
Let me know - and thanks!
There was a problem hiding this comment.
Yeah, it just shows the prototype (below) - I could just copy and paste the above for now and do a PR for Symfony with a setExample that shows all the factories
There was a problem hiding this comment.
Hmm, yea, practically for the docs, I think we should print out all of the "core" factories here.
|
I haven't forgotten about this - will work on updating this week. |
|
|
||
| # display the web debug toolbar at the bottom of pages with a summary of profiler info | ||
| toolbar: false |
There was a problem hiding this comment.
I'm going to want to keep these type of manually-added comments. So either you should keep them, or I'll add them back :). I realize that this can't be done automatically, and I think that's ok - we shouldn't need to do a wholesale re-export like this very often.
|
Thanks Kevin! Sorry for the slow attention initially on this, but I'm definitely keen to get it merged in now. I want to make sure we don't lose old comments and overall want to "change" things as little as possible (e.g. keep the full security factories instead of the prototype). See you in a few days! |
|
let me know how this looks, tried to keep the original comments. |
…uto-generated correctly - see #1303
…ough I think that most of them are still quite obtuse and will need more research and explanation - see #1303
…be more descriptive See #1303
|
Hey guys! I've just merged this in - thanks @kbond for your excellent work on this. I did make several commits tweaking small things. The biggest tweak was with the prototypes, which I think are quite confusing and, by their very nature, difficult for the generator to describe. I tried to clarify on these quickly, but I think that we still have many prototypes that are either wrong or at least a bit misleading in how they look. So, this is a big step forward, but I think the reference stuff still needs a nice human touch at some point to play with and clarify on some options. Ideally, some of that can get back into the actual code base's info tags :). Thanks! |
Note that I haven't update the xml reference. I'm not sure what we should do about that. It has fallen way behind...