Update authentication.rst #13072
Closed
Update authentication.rst #13072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we do not have to implement the ListenerInterface anymore.
|
OK, it's the same as #13069 . |
ghost
reviewed
Feb 8, 2020
There was a problem hiding this comment.
I think we do not have to implement the ListenerInterface anymore
Correct. It was deprecated in 4.4 and removed in 5.0. The upgrade guide suggests extending to AbstractListener but in the Slack community I have seen a few posts in support about making them callables:
use Symfony\Component\HttpKernel\Event\RequestEvent;
class MyListener
{
public function __invoke(RequestEvent $event)
{
// code
}
}WDYT?
HeahDude
suggested changes
Feb 9, 2020
There was a problem hiding this comment.
Thank you for that PR!
Could you check other places mentioned in #13069 as well?
I also agree that we should use __invoke in examples (#13072 (review)), the PR should target 4.4 though, so devs starting projects on the LTS don't use deprecated code. Thanks!
|
Forget my comment, we can close here in favor of #13083. |
|
Closing since #13083 has been merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we do not have to implement the ListenerInterface anymore in the example class SomeAuthenticationListener.