Skip to content

[MercureBundle] Use PublisherInterface #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

[MercureBundle] Use PublisherInterface #13234

merged 1 commit into from
Feb 25, 2020

Conversation

matthieumota
Copy link
Contributor

We must use PublisherInterface to inject Publisher service. It can cause a bug due to argument type on controller who is TraceablePublisher when profiler is enabled.

@OskarStark OskarStark modified the milestones: 3.4, 4.4 Feb 25, 2020
@OskarStark OskarStark changed the base branch from 5.0 to 4.4 February 25, 2020 09:06
@OskarStark
Copy link
Contributor

Thank you Matthieu.

@OskarStark OskarStark merged commit b1b7cb1 into symfony:4.4 Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@weeeeeeeeeeeeeeewewe weeeeeeeeeeeeeeewewe weeeeeeeeeeeeeeewewe approved these changes

Assignees
No one assigned
Labels
Mercure Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@matthieumota @OskarStark @weeeeeeeeeeeeeeewewe @carsonbot