Skip to content

Typo in allow_if condition in access_control security #13321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Typo in allow_if condition in access_control security #13321

merged 1 commit into from
Mar 10, 2020

Conversation

pohlaniacz
Copy link
Contributor

@pohlaniacz pohlaniacz commented Mar 9, 2020 •
edited
Loading

Fix typo in allow_if condition when trying to access headers. With old request.header.has('X-Secure-Access') there is a notice "Undefined property".

@pohlaniacz
Typo in allow_if condition
24ebee7 
Headers instead of header
@pohlaniacz pohlaniacz changed the base branch from master to 3.4 March 9, 2020 13:40
@javiereguiluz javiereguiluz added this to the 3.4 milestone Mar 10, 2020
@javiereguiluz
Copy link
Member

Good catch, thanks @pohlaniacz.

@javiereguiluz javiereguiluz merged commit 903b1b4 into symfony:3.4 Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@pohlaniacz @javiereguiluz @carsonbot