Skip to content

Add missing built-in normalizers #13326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

Add missing built-in normalizers #13326

merged 1 commit into from
Mar 12, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Mar 10, 2020

No description provided.

@l-vo l-vo force-pushed the add_missing_normalizers branch from c5b8731 to bcb8ee6 Compare March 10, 2020 09:33
@l-vo l-vo force-pushed the add_missing_normalizers branch from bcb8ee6 to cd379f2 Compare March 10, 2020 09:46
maxhelias
maxhelias reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment and we're good 👍

serializer.rst
* :class:`Symfony\\Component\\Serializer\\Normalizer\\DataUriNormalizer` to
transform :phpclass:`SplFileInfo` objects in `Data URIs`_
* :class:`Symfony\\Component\\Serializer\\Normalizer\\JsonSerializableNormalizer`
to deal with objects implementing the :phpclass:`JsonSerializable` interface
* :class:`Symfony\\Component\\Serializer\\Normalizer\\ArrayDenormalizer` to
denormalize arrays of objects using a format like `MyObject[]` (note the `[]` suffix)

.. _`Data URIs`: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is already present at the end of the file, you can delete the line

@javiereguiluz javiereguiluz added this to the 3.4 milestone Mar 12, 2020
@javiereguiluz
Copy link
Member

Thanks Laurent.

@javiereguiluz javiereguiluz merged commit 9890f2d into symfony:3.4 Mar 12, 2020
@l-vo l-vo deleted the add_missing_normalizers branch March 12, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias left review comments

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@l-vo @javiereguiluz @maxhelias @carsonbot