Add clear description of resolve env processor
#13417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrumann
reviewed
Mar 27, 2020
| @@ -232,8 +232,8 @@ Symfony provides the following env var processors: | |||
| ]); | |||
|
|
|||
| ``env(resolve:FOO)`` | |||
| Replaces the string ``FOO`` by the value of a config parameter with the | |||
| same name: | |||
| Replace all matches of ``%param_name%`` in the parameter ``FOO`` by the values of a config parameters with the | |||
There was a problem hiding this comment.
I agree, the description here is hard to understand and your change makes it better, but I still find this a bit hard to understand, how about:
If the value of the parameter
FOOcontains other parameters, they will be replaced with their corresponding values.
There was a problem hiding this comment.
I liked this proposal better ... but it had some issues too (e.g. FOO is not called "a parameter" in the rest of the article, etc.)
So, we reworded it as follows:
If the content of ``FOO`` includes container parameters (with the syntax
``%parameter_name%``), it replaces the parameters by their values:
Add a clear description of `resolve` env processor, describing what is actually resolved. symfony#13205
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
|
@wtorsi thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clear description of
resolveenv processor, describing what is actually resolved.#13205