Skip to content

Example should be translator not translation #13752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Example should be translator not translation #13752

merged 1 commit into from
Jun 19, 2020

Conversation

jdelaune
Copy link
Contributor

@jdelaune jdelaune commented Jun 4, 2020

No description provided.

@xabbuh xabbuh added this to the 5.1 milestone Jun 4, 2020
@javiereguiluz
Copy link
Member

@xabbuh in XML we show <framework:translation> ... is this inconsistency correct or should the other formats be updated too? Thanks

@xabbuh
Copy link
Member

xabbuh commented Jun 10, 2020

You are right. We need to change the other config formats too.

@javiereguiluz
Copy link
Member

Jordan, thanks and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 30d37d3 into symfony:5.1 Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Translation
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jdelaune @javiereguiluz @xabbuh @carsonbot