Skip to content

Fix HttpClientInterface path in HttpClient documentation #14017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix HttpClientInterface path in HttpClient documentation #14017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions http_client.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ Basic Usage
Use the :class:`Symfony\\Component\\HttpClient\\HttpClient` class to make
requests. In the Symfony framework, this class is available as the
``http_client`` service. This service will be :doc:`autowired </service_container/autowiring>`
automatically when type-hinting for :class:`Symfony\\Component\\HttpClient\\HttpClientInterface`:
automatically when type-hinting for :class:`Symfony\\Contracts\\HttpClient\\HttpClientInterface`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, but i think it is for 4.4
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Contracts/HttpClient/HttpClientInterface.php

Copy link
Contributor Author

@nicofrand nicofrand Jul 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the base to 4.4, is that OK now?


.. configuration-block::

.. code-block:: php-symfony

use Symfony\Component\HttpClient\HttpClientInterface;
use Symfony\Contracts\HttpClient\HttpClientInterface;

class SymfonyDocs
{
Expand Down