Skip to content

[Notifier] Linkedin integration #14104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ismail1432
Copy link
Contributor

Fix #14099

I'm wondering if we merge this and then I add an example like it's done https://symfony.com/doc/master/notifier/chatters.html#adding-interactions-to-a-slack-message or we wait until I add the example in 1 PR

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a need to rush merging (the stable release date is 3 months away), so feel free to keep this PR open a bit longer and add the other details (but we can also merge now if you would like that, it doesn't really matter).

notifier.rst Outdated
Comment on lines 149 to 150
The LinkedIn integration was introduced in Symfony
5.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this on one line :) (we don't have a very strict max line length rule, it should break somewhere around the 72th character)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done while merging. Thanks!

@javiereguiluz
Copy link
Member

Thank you @ismail1432.

@javiereguiluz javiereguiluz merged commit 2274677 into symfony:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notifier] Add LinkedIn provider
4 participants