-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Sempahore] Added first round of documentation #14144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@noniagriconomie Thanks for your feedback. I have addressed them |
Top, just i do not understood the « new Redis() » part, can you explain? Thx |
@noniagriconomie this class available with redis extension - https://github.com/phpredis/phpredis#classes-and-methods |
I see better thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just do not know if for the documentation it should be mentioned that the component is experimental
for now in this version :)
Hi @lyrixx! Thanks for providing a documentation PR. In the docs, we're slowly migrating to focus on framework usage. This means that instead of writing component documentation, we write framework guides. Do you maybe have time to update this documentation to instead be in
Yes, that should be mentioned :) See the 5.0 version of the string documentation for an example: symfony-docs/components/string.rst Lines 11 to 14 in a7e9a6f
|
Grégoire, thanks for contributing this feature and its docs too. This is now merged! |
refs #14139