Add AMPS support entry #14250
Add AMPS support entry #14250
Conversation
messenger.rst
Outdated
|
|
||
| Starting from Symfony 5.2, the AMQP transport can handle AMQPS DSN (e.g. ``amqps://``). | ||
| Be aware that using it without using CA certificate can throw an exception. | ||
| An alternative is to use AMQP DSN and to specify which port you want to use (e.g. ``amqp://localhost?port=5671``). |
There was a problem hiding this comment.
We often avoid introducing new information in versionadded directives. When the version reached end-of-life, we simply remove all old versionadded directives - it would be sad to loose usefull information.
So I would suggest you say this information somewhere below in the text. I think the best is to add a real example to the .env example on line 866, e.g.:
# .env
MESSENGER_TRANSPORT_DSN=amqp://guest:guest@localhost:5672/%2f/messages
# or use the AMQPS protocol
MESSENGER_TRANSPORT_DSN=amqps://...
You can then also show a working DNS string (so people see how to configure the required CA certificate). After the example, you can then add a short versionadded directive:
.. versionadded:: 5.2
Support for the AMQPS DSN was introduced in Symfony 5.2.There was a problem hiding this comment.
Wdyt about the changes ?
| .. versionadded:: 5.2 | ||
|
|
||
| Starting from Symfony 5.2, the AMQP transport can handle AMQPS DSN (e.g. ``amqps://``). | ||
| Be aware that using it without using CA certificate can throw an exception. |
There was a problem hiding this comment.
This sentence isn't really helpful. How do I set this CA certificate? We should either not mention it (and rely on Symfony to throw an exception that will educate the user on what to do next) or fully show how to use amps.
There was a problem hiding this comment.
I've added an entry about it, wdyt ?
|
Please associate your email address with your Github account, or change the |
Should be fine :) I've used my firstname and lastname and my pro email. This should be enough no ? |
It doesn't seem to work. Did you link your pro email to your account? |
Fixed (finally!) I had a private email before I had a pro address. Thank you! |
|
Thank you Valentin. This is now merged! Note that we did some minor rewords and simplifications while merging. |
Fix #14249