Skip to content

Getting a stack trace follow up #14263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Sep 21, 2020

Here are fixes for issues I noticed only now 🤦 (sorry)

There is one issue I don't know how to fix: although I put a gif in _images/contributing/code/stack-trace.gif, and linked to it with

.. image:: /_images/contributing/code/stack-trace.gif
, it is served at at least this url: https://symfony.com/doc/4.4/_images/stack-trace.gif (and the link does not render properly, of course)

What did I do wrong?

Screenshot_2020-09-21 Getting a Stack Trace (Symfony Docs)

@greg0ire greg0ire changed the title ues Getting a stack trace follow up Getting a stack trace follow up Sep 21, 2020
@xabbuh xabbuh added this to the 4.4 milestone Sep 22, 2020
@greg0ire
Copy link
Contributor Author

greg0ire commented Sep 22, 2020

Does anyone know how to fix the image issue?

Why does this work for https://symfony.com/doc/current/components/console/helpers/progressbar.html

The url of the gif in that page is not what I expect it to be (it doesn't mention components/console), but it works. Also, when I build the docs locally, it works too…

@greg0ire
Copy link
Contributor Author

greg0ire commented Sep 22, 2020

Ah something I did not notice: the gif works on this page: https://symfony.com/doc/4.4/contributing/code/stack_trace.html#stack-traces-in-your-web-browser, but not on 5.1, 5.2, or current. It looks like a deploy issue, maybe?

@OskarStark
Copy link
Contributor

@javiereguiluz could you have a look? Thanks

@javiereguiluz javiereguiluz force-pushed the getting-a-stack-trace-follow-up branch from 68209b1 to 4c14bfb Compare September 23, 2020 16:01
@javiereguiluz javiereguiluz merged commit 6aee739 into symfony:4.4 Sep 23, 2020
@javiereguiluz
Copy link
Member

Thanks! I've merged these fixes and I've created an issue in the private symfony.com repo to debug the problem with the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants