Skip to content

Update framework.rst #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ThomasLandauer
Copy link
Contributor

Fixing headers format to be consistent with the code block at https://symfony.com/doc/4.4/reference/configuration/framework.html#http-client

Fixing `headers` format to be consistent with the code block at https://symfony.com/doc/4.4/reference/configuration/framework.html#http-client
@xabbuh
Copy link
Member

xabbuh commented Oct 5, 2020

This looks confusing to me. I think someone reading the docs would not expect to have some random config example in YAML. If there is clarification needed, we should rather add proper code blocks for the different formats IMO.

@xabbuh xabbuh added this to the 4.4 milestone Oct 5, 2020
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. Im not sure this is more helpful.

@ThomasLandauer
Copy link
Contributor Author

Uhm, sorry guys, the point is that the existing ['header-name' => header-value, ...] is just not working cause it's the wrong syntax. So what's your plan? Leave it as is?

@Nyholm
Copy link
Member

Nyholm commented Oct 8, 2020

I think it is the correct syntax for the normalized PHP value. It is also meant to show that it should not be ['header-name' => ['header-value']].

Could you add ' around "header-value" and I would be happy with that to be the only change.

@ThomasLandauer
Copy link
Contributor Author

Could you add ' around "header-value" and I would be happy with that to be the only change.

Do you mean in the yaml or the php syntax?

The entire page is in yaml syntax...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants