[Messenger] Update the list of stamp #14374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Oct 8, 2020
components/messenger.rst
Outdated
| #. :class:`Symfony\\Component\\Messenger\\Stamp\\DelayStamp`, | ||
| to delay handling of an asynchronous message. | ||
| #. :class:`Symfony\\Component\\Messenger\\Stamp\\DispatchAfterCurrentBusStamp`, | ||
| to make the message be handled after the current buss has executed. Read more |
There was a problem hiding this comment.
I slipped in some Swedish. Sorry about that.
There was a problem hiding this comment.
And I don't know how it could be added, but if the treatment has been successful no?
|
A quick question: do these changes apply to 4.4 or 5.1 too? Or are the newly added stamps 5.x only? Thanks! |
|
Correct. It applies to 4.4 and 5.1 too. Should I be more careful selecting base branch in the future? |
|
No worries. It's common to have to change the branch while merging. We can do that with the tool we use to merge things, so it doesn't mean more work for maintainers. I'm going to merge it in 4.4 and up. Thanks! |
javiereguiluz
force-pushed
the
messenger-stamps
branch
from
fd1612a to
728f89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the list of stamps. In the current docs it looks like the list of stamps was complete. I think we should just highlight important ones that users will come in contact with. Advanced users will find the rest of the stamps anyways.
I sorted the list alphabetically. I added DelayStamp and DispatchAfterCurrentBusStamp