Skip to content

[Messenger] Routing & Inheritance #14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

[Messenger] Routing & Inheritance #14430

merged 1 commit into from
Apr 7, 2021

Conversation

sylfabre
Copy link
Contributor

This PR details how Messenger deals with messages and inheritance.

We were discussing with my colleagues and had to do a quick POC to find out as it is not documented, and we had some doubt about it.

@sylfabre sylfabre force-pushed the messenger_override branch 2 times, most recently from 6c99120 to 6c39842 Compare October 16, 2020 16:05
OskarStark
OskarStark reviewed Oct 21, 2020
View reviewed changes
OskarStark
OskarStark reviewed Oct 21, 2020
View reviewed changes
OskarStark
OskarStark reviewed Oct 21, 2020
View reviewed changes
@sylfabre
Copy link
Contributor Author

@OskarStark thank you for your review.

Anything else I should do to get it merged?

Matts
Matts suggested changes Oct 27, 2020
View reviewed changes
Copy link

@Matts Matts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylfabre After these changes LTGM

@sylfabre
Copy link
Contributor Author

@Matts done, thank you for your review

Matts
Matts approved these changes Oct 27, 2020
View reviewed changes
Copy link

@Matts Matts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so sorry! It seems the CI does not agree with my interpretation. Did not know that an empty line after a start of the code block is a requirement. See the required changes below. Will approve it now seeing as this is blocked by CI

@sylfabre
Copy link
Contributor Author

@Matts no worries!

@sylfabre sylfabre closed this Feb 2, 2021
@sylfabre sylfabre deleted the messenger_override branch February 2, 2021 12:18
@sylfabre sylfabre restored the messenger_override branch March 4, 2021 14:01
@sylfabre sylfabre reopened this Mar 4, 2021
@sylfabre
Copy link
Contributor Author

sylfabre commented Mar 4, 2021 •
edited
Loading

I don't why I closed it a month ago ...

@sylfabre sylfabre force-pushed the messenger_override branch 2 times, most recently from ba8463c to a21e09d Compare March 4, 2021 14:29
@wouterj wouterj changed the base branch from 5.x to 4.4 April 7, 2021 13:14
@wouterj wouterj requested a review from xabbuh as a code owner April 7, 2021 13:14
@wouterj wouterj force-pushed the messenger_override branch from a21e09d to f5ee472 Compare April 7, 2021 13:14
@wouterj wouterj merged commit 32a73b0 into symfony:4.4 Apr 7, 2021
@wouterj
Copy link
Member

wouterj commented Apr 7, 2021

Thank you @sylfabre for the research & documentation. I've slightly reduced the content and moved it up a bit (as we already talk a bit about inheritance at the start of the section).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@Matts Matts Matts approved these changes

@maxhelias maxhelias maxhelias approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sylfabre @wouterj @OskarStark @Matts @maxhelias @carsonbot