[Console][Mailer][Security] Added PHP type declarations #14591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
carsonbot
changed the title
carsonbot
changed the title
OskarStark
reviewed
Nov 23, 2020
OskarStark
reviewed
Nov 23, 2020
OskarStark
reviewed
Nov 23, 2020
OskarStark
reviewed
Nov 23, 2020
wouterj
force-pushed
the
types/console-flex-security-mailer
branch
from
663a23e to
b33b6b5
Compare
|
Wouter, will you have the time and motivation of completing this contribution? I know it's a lot of work ... but if we keep it unmerged, the list of merge conflicts will keep growing 😢 |
|
Hi! Is there anything left, other than a rebase to fix the conflicts? |
|
In my opinion this is finished and ready! |
wouterj
force-pushed
the
types/console-flex-security-mailer
branch
from
b33b6b5 to
362aa61
Compare
|
Alright, ready to go then :). The merge conflict were fortunately very easy (they all conflicted with the recent diff whitespace changes we made) |
javiereguiluz
force-pushed
the
types/console-flex-security-mailer
branch
from
362aa61 to
23dc098
Compare
|
Merged! Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues some work on #12235 for the next 3 most popular topics: security, mailer and console.