Skip to content

[Uid] Update uid.rst #14710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020
Merged

[Uid] Update uid.rst #14710

merged 1 commit into from
Dec 18, 2020

Conversation

ltlsquare
Copy link
Contributor

Uuid::fromString(); should not be instantiated as "new".
The Ulid section is correct the uuid section contains this error.
Especially confusing when you are just starting with this newly implemented functionality.

@OskarStark OskarStark added the Uid label Dec 18, 2020
@carsonbot carsonbot changed the title Update uid.rst [Uid] Update uid.rst Dec 18, 2020
@OskarStark OskarStark self-assigned this Dec 18, 2020
@OskarStark OskarStark modified the milestones: 5.2, 5.1 Dec 18, 2020
@OskarStark OskarStark changed the base branch from 5.2 to 5.1 December 18, 2020 07:25
@OskarStark OskarStark requested a review from HeahDude as a code owner December 18, 2020 07:25
Uuid::fromString(); should not be instantiated as "new".
The Ulid section is correct the uuid section contains this error. 
Especially confusing when you are just starting with this newly implemented functionality.
@OskarStark
Copy link
Contributor

Good catch, thanks Fouad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants