[DependencyInjection] Fix possible error in example code #14729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp1ker
changed the title
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
carsonbot
changed the title
javiereguiluz
changed the title
Pseudo-type `iterable` accepts any `array` or `object` implementing the `Traversable` interface. Constructor will be crashed when we try to pass array instead of `Traversable` and use `iterator_to_array`. `iterator_to_array` dont work with arrays. Then if always passing `Traversable` we could write like this: ```php public function __construct(Traversable $handlers) ``` or check instance on `Traversable`.
|
Nice fix Evgeniy! Thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pseudo-type
iterableaccepts anyarrayorobjectimplementing theTraversableinterface. Constructor will be crashed when we try to pass array instead ofTraversableand useiterator_to_array.iterator_to_arraydont work with arrays.Then if always passing
Traversablewe could write like this:or check instance of
Traversable.