Skip to content

[Session] Update incorrect default value for session.handler_id #14734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

[Session] Update incorrect default value for session.handler_id #14734

merged 1 commit into from
Dec 28, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 22, 2020 •
edited
Loading

@carsonbot carsonbot added this to the 4.4 milestone Dec 22, 2020
@wouterj
Copy link
Member

wouterj commented Dec 23, 2020 •
edited
Loading

null and ~ are the same in Yaml afaics, so they should both be A, right? The other changes seem correct to me.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 23, 2020

Thank you.. But how will this line ever be true?

https://github.com/symfony/symfony/blob/73a3b838b742f103033218a2758548b829d27061/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L949

@Nyholm
Copy link
Member Author

Nyholm commented Dec 23, 2020

Because the default value is only there if we dont set handler_id. Fair.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 23, 2020

PR description is updated

@javiereguiluz
Copy link
Member

Thank you Tobias.

@javiereguiluz javiereguiluz merged commit daa3137 into symfony:4.4 Dec 28, 2020
@Nyholm Nyholm deleted the session-handler branch December 28, 2020 13:55
@Nyholm
Copy link
Member Author

Nyholm commented Dec 28, 2020

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Session Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @wouterj @javiereguiluz @carsonbot