Skip to content

language tweak #14766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2021
Merged

language tweak #14766

merged 1 commit into from
Jan 2, 2021
+1 −1

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Dec 30, 2020

"At last" means after a delay, lastly is just the last thing on the list.

@OskarStark OskarStark added this to the 4.4 milestone Dec 31, 2020
wouterj
wouterj approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining the change for a non-native speaker! I learned something new at the last day of 2020 :)

@xabbuh xabbuh changed the base branch from 5.2 to 4.4 January 2, 2021 11:29
@tacman @xabbuh
language tweak
978492d 
"At last" means after a delay, lastly is just the last thing on the list.
@xabbuh xabbuh requested review from HeahDude and xabbuh as code owners January 2, 2021 11:29
@xabbuh
Copy link
Member

xabbuh commented Jan 2, 2021

Thank you @tacman.

@xabbuh xabbuh merged commit 1ff60fd into symfony:4.4 Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@tacman @xabbuh @wouterj @OskarStark @carsonbot