Skip to content

Remove react packages from the main dependencies #14867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mradhi
Copy link

@mradhi mradhi commented Jan 22, 2021

No needs to install react packages in the main dependencies inside the package.json file.

No needs to install react packages in the main dependencies inside the package.json file.
@javiereguiluz
Copy link
Member

Thanks for this proposal. I'm not sure if this was made on purpose, so let's ask to experts like @Lyrkan and @Kocal to see if they agree with this change. Thanks!

@Kocal
Copy link
Member

Kocal commented Jan 22, 2021

Hey 👋

Well, in fact it does not really matters since React will be bundled through Webpack Encore. Having it as a prod dependency or dev dependency will give the same result.

However, we prefer to keep building tools (like Webpack Encore and loaders, ESLint, Stylelint, etc ...) as dev dependencies, and "runtime deps" (the one used in the browser like React, Vue, Bootstrap, ...) in "prod" dependencies.

So the current documentation is correct, for me.

@javiereguiluz
Copy link
Member

@Kocal thanks for your detailed response (and thanks @Lyrkan for confirming it). Let's close without merging then, because of the reasons explained in the previous comment.

Mohamed, this time your contribution wasn't merged (and it's sad because it would have been your first one in this repository) but there will be more contribution opportunities in the future. Thanks!

@mradhi mradhi deleted the patch-2 branch January 22, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants