Skip to content

Fix typo in SVG image #14925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo in SVG image #14925

wants to merge 1 commit into from

Conversation

BenMorel
Copy link
Contributor

@BenMorel BenMorel commented Feb 4, 2021

Addres => Address

@BenMorel
Fix typo in SVG image
8bc9e9b 
`Addres` => `Address`
@javiereguiluz
Copy link
Member

Thanks for fixing this! However, the full fix requires to fix the original image file (stored in https://github.com/symfony/symfony-docs/tree/4.4/_images) and then exporting it to SVG and optimizing it with svgo. It's a cumbersome process, so we can do it for you if you prefer.

@BenMorel
Copy link
Contributor Author

BenMorel commented Feb 4, 2021

Hi, the original image file is the one I edited, isn't it? Should I just optimize it with svgo?

@javiereguiluz
Copy link
Member

Sorry, I meant the original image in https://github.com/symfony/symfony-docs/tree/4.4/_images/sources. which requires installing a certain application, etc.

@BenMorel
Copy link
Contributor Author

BenMorel commented Feb 5, 2021

Oh right, I'm happy to let you do it then! 😉

@javiereguiluz javiereguiluz mentioned this pull request Apr 21, 2021
Merged
@javiereguiluz
Copy link
Member

Closing in favor of #15271. Thanks!

javiereguiluz added a commit that referenced this pull request Apr 21, 2021
@javiereguiluz
minor #15271 Fixed some typos in some images (javiereguiluz)
fb59362 
This PR was merged into the 4.4 branch.

Discussion
----------

Fixed some typos in some images

This finishes #14925.

Commits
-------

e7cf354 Fixed some typos in some images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMorel @javiereguiluz @carsonbot