[Mailer] Improve documentation for mailer failover and round-robin transports #14957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current documentation for the failover transport is not correct.
This isn't what really happens. In my tests (and from studying the code), it seems that the mailer simply retries with the next available transport.
This is also what one would expect from a failover. Failing the first time something goes wrong isn't really a failover ;-)
So the only difference between failover and round-robin is that the latter selects a transport at random. My proposed change reflects that more clearly.