Skip to content

[Routing] Adding exclude to PHP code sample #14968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

[Routing] Adding exclude to PHP code sample #14968

merged 1 commit into from
Apr 16, 2021

Conversation

ThomasLandauer
Copy link
Contributor

Was missing there...

@carsonbot carsonbot added this to the 4.4 milestone Feb 13, 2021
@ThomasLandauer
Copy link
Contributor Author

Is this really the correct way to do it? Cause phpstan gives me:

Call to an undefined method Symfony\Component\Routing\Loader\Configurator\ImportConfigurator::exclude()

javiereguiluz
javiereguiluz reviewed Feb 15, 2021
View reviewed changes
@carsonbot carsonbot changed the title Adding exclude to PHP code sample [Routing] Adding exclude to PHP code sample Apr 16, 2021
@javiereguiluz javiereguiluz merged commit 52b500d into symfony:4.4 Apr 16, 2021
@javiereguiluz
Copy link
Member

Thanks Thomas! This was finally merged.

@ThomasLandauer ThomasLandauer deleted the patch-3 branch April 16, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @javiereguiluz @carsonbot