-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fixed cs of php parts #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed cs of php parts #1497
Changes from 1 commit
9eeb2a9
8b2e250
f4422d1
970c7c1
ff2631f
66ca932
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,11 +25,11 @@ will enter the issue number. The field will display an error if a non existing n | |
was entered:: | ||
|
||
// src/Acme/TaskBundle/Form/Type/IssueSelectorType.php | ||
|
||
namespace Acme\TaskBundle\Form\Type; | ||
|
||
use Symfony\Component\Form\AbstractType; | ||
use Symfony\Component\Form\FormBuilderInterface; | ||
use Symfony\Component\OptionsResolver\OptionsResolverInterface; | ||
use Acme\TaskBundle\Form\DataTransformer\IssueToNumberTransformer; | ||
use Doctrine\Common\Persistence\ObjectManager; | ||
|
||
|
@@ -137,7 +137,7 @@ Next, we create the data transformer, which does the actual conversion:: | |
/** | ||
* Transforms a string (number) to an object (issue). | ||
* | ||
* @param string $number | ||
* @param string $number | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a standard, you need to align all variable names and there description, but not the variable name and a description of another item without a variable name (e.g. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. php cs fixer was used There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yea, this seems odd - what if I can't really argue with the phpcs, but this one almost feels wrong :/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @weaverryan reverted ;) |
||
* @return Issue|null | ||
* @throws TransformationFailedException if object (issue) is not found. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be reverted, because it is used in the next code block (and this code is included there because of the
...
).Or, maybe better, place this line in the next code block. I think that's the best option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wouterj done thank you ;)