Update the default cookie_secure
value in framework.rst
#14999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-secure cookies was introduced in Symfony 4.2. In Symfony 4.4, according to the Framework Configuration Reference, the default value for
cookie_secure
is 'auto'. "Auto" means that the framework will set thecookie_secure
flag totrue
when the traffic is sent through HTTPS, orfalse
otherwise.Since 5.0, the value for this "auto" behavior is changed to
null
according to the Framework Configuration Reference documentation (the doc change happened somewhere in Jan 2020, I could not pinpoint the exact commit that caused this though). That said, I can still find "auto" being mentioned in the session documentation. It is still the default configuration value of a new Symfony 5.2 project. Also, in the Symfony\Bundle\FrameworkBundle\DependencyInjection\Configuration class, I can see that "auto" (but not null) being one of the allowed values.So, I believe the behavior in the framework hasn't been changed, and the documentation change in
framework.rst
was not an intentional one. This PR updates the currentframework.rst
with the correct value.