Skip to content

Typo with backticks. #15138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

Typo with backticks. #15138

merged 1 commit into from
Mar 23, 2021

Conversation

askeita
Copy link
Contributor

@askeita askeita commented Mar 22, 2021

Removed extra backticks that are visible.

@OskarStark OskarStark added this to the 4.4 milestone Mar 23, 2021
@askeita @OskarStark
Typo with backticks.
e1ca152 
Removed extra backticks.
@OskarStark OskarStark changed the base branch from 5.2 to 4.4 March 23, 2021 12:00
@OskarStark OskarStark requested a review from xabbuh as a code owner March 23, 2021 12:00
@OskarStark
Copy link
Contributor

Good catch, thanks @askeita.

@OskarStark OskarStark merged commit afde6ab into symfony:4.4 Mar 23, 2021
@xabbuh
Copy link
Member

xabbuh commented Mar 23, 2021 •
edited
Loading

Doesn't this look weird? What about rewording this to "ETag headers" instead?

@askeita
Copy link
Contributor Author

askeita commented Mar 23, 2021

Good catch, thanks @askeita.

Thanks @OskarStark !

@askeita askeita deleted the patch-2 branch March 23, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@askeita @OskarStark @xabbuh @Nyholm @carsonbot