Skip to content

[Security] Customize generated Login Link #15163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2021
Merged

[Security] Customize generated Login Link #15163

merged 1 commit into from
Apr 21, 2021

Conversation

roromix
Copy link
Contributor

@roromix roromix commented Mar 28, 2021

Fix #15147 and add documentation for symfony/symfony#40641

@roromix roromix changed the title Customize generated Login Link [Security] Customize generated Login Link Mar 28, 2021
@roromix roromix changed the title [Security] Customize generated Login Link WIP:[Security] Customize generated Login Link Mar 30, 2021
@roromix roromix changed the title WIP:[Security] Customize generated Login Link [Security] Customize generated Login Link Mar 30, 2021
@roromix roromix requested a review from OskarStark April 1, 2021 12:19
fabpot added a commit to symfony/symfony that referenced this pull request Apr 2, 2021
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

LoginLink create get Request Locale

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#15163

While writing the documentation for PR#40153 I noticed that the RequestContext :: fromRequest method does not add the '_locale' parameter automaticaly. This new pull request to set _locale parameter to the RequestContext.

Commits
-------

433d76b LoginLink create get Request Locale
@javiereguiluz javiereguiluz added this to the 5.3 milestone Apr 21, 2021
@javiereguiluz javiereguiluz merged commit 5137e22 into symfony:5.x Apr 21, 2021
@javiereguiluz
Copy link
Member

Romain, thanks a lot for contributing these docs ... and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] LoginLink with specific locale
4 participants