Skip to content

[Lock] Update table in lock component #15226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

zozs
Copy link
Contributor

@zozs zozs commented Apr 12, 2021

The table on the locks documentation does not seem to be consistent with the description for PostgreSqlStore. The table currently says the locks are expiring, while the textual descriptions further down the page says the opposite:

the PostgreSqlStore does not need a table to store locks and does not expire.

and

That means that by using :ref:PostgreSqlStore <lock-store-pgsql> the locks will be automatically released at the end of the session in case the client cannot unlock for any reason.

Proposed fix, modify the table so it says no under the Expiring column for PostgreSqlStore.

@carsonbot carsonbot changed the title Update table in lock component [Lock] Update table in lock component Apr 12, 2021
@javiereguiluz
Copy link
Member

Linus, thanks for fixing this error and thanks for the detailed explanation!

Congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 23c448c into symfony:5.2 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants