Skip to content

Recommend using root controller attribute in route definition #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

Recommend using root controller attribute in route definition #15282

merged 1 commit into from
May 3, 2021

Conversation

andrew-demb
Copy link
Contributor

Also, it is consistent with the example above:

# config/routes.yaml
hello:
    path:     /hello
    controller: App\Controller\HelloController::index
    methods: GET

Checked on Symfony 5.2.6

@carsonbot carsonbot added this to the 4.4 milestone Apr 23, 2021
javiereguiluz
javiereguiluz reviewed Apr 23, 2021
View reviewed changes
@javiereguiluz
Copy link
Member

Merged! Thanks.

@javiereguiluz javiereguiluz merged commit 696c423 into symfony:4.4 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-demb @javiereguiluz @carsonbot