Skip to content

[Serializer] match example with description above #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

[Serializer] match example with description above #15296

merged 1 commit into from
Apr 28, 2021

Conversation

iamvar
Copy link
Contributor

@iamvar iamvar commented Apr 28, 2021

Discriminator description mentions abstract class, but example contains interface

@OskarStark OskarStark added this to the 4.4 milestone Apr 28, 2021
@OskarStark OskarStark changed the base branch from 5.x to 4.4 April 28, 2021 06:58
@OskarStark
Copy link
Contributor

OskarStark commented Apr 28, 2021 •
edited
Loading

Good catch, thanks Vladimir and congrats on your first contribution to the Symfony documentation 🎉

@OskarStark OskarStark merged commit 607f5be into symfony:4.4 Apr 28, 2021
@iamvar iamvar deleted the discriminator-example branch April 28, 2021 07:05
@iamvar iamvar mentioned this pull request May 1, 2021
Merged
@iamvar
Copy link
Contributor Author

iamvar commented May 1, 2021

Do we also need to update examples in 5.0, 5.1?
Changes were merged in 4.4 and 5.x

javiereguiluz added a commit that referenced this pull request May 3, 2021
@javiereguiluz
minor #15302 [Serializer] update example for attributes (iamvar)
abec79a 
This PR was submitted for the 5.x branch but it was merged into the 5.2 branch instead.

Discussion
----------

[Serializer] update example for attributes

update attributes example as well
see #15296

Commits
-------

19b8d23 update example for attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@iamvar @OskarStark @carsonbot