Skip to content

[Testing] Application testing in Symfony is fun! Let's document the modern features #15304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 2, 2021

This PR continues the efforts of restructuring the Testing docs:

  • Focus more on Arrange, Act, Assert
  • Advertise modern testing features (assertions). Somehow, we didn't mention any easy to use assertion in the main guide, but instead explained the complex dom crawler API.
  • Reduce some "duplication". There is an astonishing number of ways to fill in and submit a form (we documented at least 4 different APIs in the main guide!). I've reduced this to two: a plain and short one, and a longer one for more complex form submissions.

Todo, preferably in a follow-up PR: combine the testing/dom_crawler and components/dom_crawler feature documentation into testing/dom_crawler.

cc @Nyholm

- Focus more on Arrange, Act, Assert
- Advertise modern testing features: application testing in Symfony is fun!
- Move all important application test docs into the main guide
@wouterj wouterj force-pushed the testing-dom-crawler branch from b437a29 to 4f72e6a Compare May 2, 2021 11:56
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! It's a nice simplification + reorganization. Thanks Wouter!

@javiereguiluz
Copy link
Member

Thanks Wouter! This is now merged.

@wouterj wouterj deleted the testing-dom-crawler branch May 3, 2021 09:44
@wouterj
Copy link
Member Author

wouterj commented May 3, 2021

Thank you @javiereguiluz. If you need help with the up merging, feel free to ping me :)

@javiereguiluz
Copy link
Member

I've just finished upmerging. I think I did it right, but I'm not 100% sure, so maybe you could check the result. Thanks! I'll let you merge the other one (#15305) so you can easily spot the confilcts 🙏 Thanks!

@nanasess nanasess mentioned this pull request May 17, 2022
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants