Skip to content

Updating to PHP 7.4 #15308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Updating to PHP 7.4 #15308

merged 1 commit into from
May 6, 2021

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

@carsonbot carsonbot added this to the 4.4 milestone May 3, 2021
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we support PHP 7.2 so we should use that instead

@javiereguiluz
Copy link
Member

Oskar, it's true that the minimum PHP version supported by Symfony is 7.2 ... but that's an unsupported version. That's why I think this change could make sense. My vote would be 👍 but I'm not sure if this could introduce any issues.

@ThomasLandauer
Copy link
Contributor Author

The idea was to make it copy-pastable. Nobody who is starting a new project (which is the audience of this page) will go for anything prior to 7.4 today.
The existing numbers don't fit for everybody, and the new ones won't also - so IMO there can't be any issues ;-)

@OskarStark
Copy link
Contributor

Agree then 👍

@javiereguiluz
Copy link
Member

Thank you Thomas.

@javiereguiluz javiereguiluz merged commit c65c4b1 into symfony:4.4 May 6, 2021
@ThomasLandauer ThomasLandauer deleted the patch-21 branch May 6, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants