Skip to content

[Console] Add explicit note about the type of VALUE_NONE #15309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

[Console] Add explicit note about the type of VALUE_NONE #15309

merged 1 commit into from
May 21, 2021

Conversation

melkamar
Copy link
Contributor

@melkamar melkamar commented May 4, 2021

It was not clear what the default value nor what the type returned
from InputOption::VALUE_NONE is.

@melkamar @javiereguiluz
Add explicit note about the type of VALUE_NONE
403cb33 
It was not clear what the default value nor what the type returned
from InputOption::VALUE_NONE is.
@javiereguiluz javiereguiluz changed the base branch from 5.2 to 4.4 May 21, 2021 11:05
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner May 21, 2021 11:05
@carsonbot carsonbot changed the title Add explicit note about the type of VALUE_NONE [Console] Add explicit note about the type of VALUE_NONE May 21, 2021
@javiereguiluz
Copy link
Member

Thanks Martin.

@javiereguiluz javiereguiluz merged commit 1b23779 into symfony:4.4 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melkamar @javiereguiluz @carsonbot