Unifying to "configuration parameters" #15326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are multiple words for the same thing: * configuration parameter * config parameter * container parameter An on https://symfony.com/doc/current/best_practices.html#use-constants-to-define-options-that-rarely-change: * service container parameter Since the dedicated chapter at https://symfony.com/doc/current/configuration.html#configuration-parameters calls it "configuration parameter", I'd say all of them should be changed to that. Do you agree? Then I'll commit the rest.
|
Generally speaking, I'd say we should do this change 👍 (if some specific case looks much worse after that change, we could revert that occurrence and keep the other changes). Also, if possible let's do this change in 4.4 branch. Thanks! |
ThomasLandauer
added a commit
to ThomasLandauer/symfony-docs
that referenced
this pull request
May 11, 2021
|
OK. Closing this in favor of #15328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are multiple words for the same thing:
An on https://symfony.com/doc/current/best_practices.html#use-constants-to-define-options-that-rarely-change:
Since the dedicated chapter at https://symfony.com/doc/current/configuration.html#configuration-parameters calls it "configuration parameter", I'd say all of them should be changed to that. Do you agree? Then I'll commit the rest.