Skip to content

[RateLimiter] [Rate Limiter] Added missing opening single quotes #15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2021
Merged

[RateLimiter] [Rate Limiter] Added missing opening single quotes #15346

merged 1 commit into from
May 17, 2021

Conversation

artyuum
Copy link
Contributor

@artyuum artyuum commented May 15, 2021

Added the missing opening single quotes in the PHP config example

@artyuum
[Rate Limiter] Added missing opening single quotes
87dbab9 
Added the missing opening single quotes in the PHP config example
OskarStark
OskarStark approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Nyholm

Nyholm
Nyholm approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I was sure I fixed that before.. Anyhow =)

@Nyholm Nyholm mentioned this pull request May 16, 2021
Merged
javiereguiluz added a commit that referenced this pull request May 17, 2021
@javiereguiluz
minor #15348 [RateLimiter] Fix syntax error in config (Nyholm)
06f0f5b 
This PR was merged into the 5.2 branch.

Discussion
----------

[RateLimiter] Fix syntax error in config

This is not the same as #15346

Commits
-------

57aa49a Fix syntax error
@carsonbot carsonbot changed the title [Rate Limiter] Added missing opening single quotes [RateLimiter] [Rate Limiter] Added missing opening single quotes May 17, 2021
@javiereguiluz javiereguiluz added this to the 5.2 milestone May 17, 2021
@javiereguiluz
Copy link
Member

Thanks @artyuum.

@javiereguiluz javiereguiluz merged commit b316587 into symfony:5.2 May 17, 2021
@artyuum artyuum deleted the patch-1 branch May 21, 2021 12:14
@artyuum artyuum restored the patch-1 branch May 21, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
RateLimiter Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@artyuum @javiereguiluz @OskarStark @Nyholm @carsonbot