Skip to content

Update NuSOAP client example #15350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged

Update NuSOAP client example #15350

merged 1 commit into from
May 19, 2021

Conversation

sebpacz
Copy link
Contributor

@sebpacz sebpacz commented May 17, 2021

The $soapClient created in the example is an instance of the native \SoapClient class, instead of NuSOAP.

@carsonbot carsonbot added this to the 4.4 milestone May 17, 2021
@javiereguiluz
Copy link
Member

Thanks for reporting this.

Apparently, NuSOAP was updated for the last time in 2016: https://sourceforge.net/projects/nusoap/

So, we should rewrite this example to use pure PHP SOAP code: https://www.php.net/manual/en/class.soapclient.php @sebpacz do you know SOAP well enough to do this? Are you willing (and will you have time) to do it? Thanks!

@sebpacz
Copy link
Contributor Author

sebpacz commented May 18, 2021

Hi @javiereguiluz,

I've updated this example. Using the native client in this case is a good idea.

@javiereguiluz
Copy link
Member

Thank you Sebastian.

@javiereguiluz javiereguiluz merged commit 8147243 into symfony:4.4 May 19, 2021
@sebpacz sebpacz deleted the patch-4 branch May 20, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants